featzhang commented on PR #27774:
URL: https://github.com/apache/flink/pull/27774#issuecomment-4365141816
Polishing pass before first review:
1. **Lag sentinel → nullable.** `SourceLagInfo.{pendingRecords,
maxFetchEventTimeLagMs, maxEmitEventTimeLagMs}` are now `Double` (wire-level
`null`) instead of the `-1.0` magic number. This avoids conflating
"unavailable" with a legitimate 0 and makes the UI rendering path (`formatLag`
→ `"n/a"`) explicit. Ranking uses `Comparator.nullsFirst(..).reversed()` so
vertices with real data still float to the top.
2. **History squashed to 2 commits** (force-pushed): `Add Top N Metrics
Dashboard` (3 sections — original scope) and `Expand to 5 sections` (subtask
backpressure / busy + FLIP-33 source lag + `null` semantics). All 11 process
commits (snapshot regen, package-lock revert, formatting cleanups, etc.) are
folded into the relevant parent.
Local verification: `TopNMetricsHandlerTest` + `TopNQueryParameterTest` (20
tests) and `RuntimeRestAPIStabilityTest` all green; spotless clean.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
