featzhang commented on PR #27774:
URL: https://github.com/apache/flink/pull/27774#issuecomment-4414691402

   > HI, @featzhang Thank you for your contirbution. Since this change involves 
modifications to the REST API, initiating a FLIP discussion is probably the 
safest approach.
   
   Hi @RocMarshal, thanks a lot for the careful review and the heads-up on the 
FLIP process — fully agree that REST API changes warrant a FLIP.
   
   Quick status update:
   
   1. **JIRA / DISCUSS thread** — I already opened the discussion under 
[FLINK-39489](https://issues.apache.org/jira/browse/FLINK-39489) ("[web 
dashboard] Add Top N Metrics Dashboard to Flink Web UI") to gather early 
feedback, but it hasn't received any replies yet.
   2. **FLIP draft** — A FLIP draft is also ready (covering motivation, public 
REST API additions, Web UI changes, compatibility & rejected alternatives). 
Draft link: 
https://docs.google.com/document/d/1Cq2G1zVWCWmjJNdtO9Cm4vzuDMHIUgyBTldBZZAxNR0/edit
   3. **End-to-end verification** — The feature in this PR has already been 
deployed and validated on a real cluster. Screenshots of the Top N Metrics 
Dashboard running against a live JobManager are attached below for reference, 
so reviewers can see the actual UX while the FLIP discussion is ongoing.
   
      
   <img width="3146" height="2174" alt="image" 
src="https://github.com/user-attachments/assets/55d50267-1355-4d3f-936e-0b8bb478753a";
 />
   
      <details>
      <summary>Screenshots — Top N Metrics Dashboard (click to expand)</summary>
   
      **1. Cluster-level Top N Overview**
      ![overview](<paste-screenshot-url-1>)
   
      **2. Per-Job Top N Metric tab**
      ![per-job](<paste-screenshot-url-2>)
   
      **3. REST API response sample (`/jobs/:jobid/topn-metrics`)**
      ![rest-api](<paste-screenshot-url-3>)
   
      </details>
   
   Next steps I plan to take, please let me know if this matches the 
community's expectation:
   
   - Send a `[DISCUSS] FLIP-XXX: Add Top N Metrics Dashboard to Flink Web UI` 
thread to **[email protected]**, with the JIRA, this PR, the FLIP draft and 
the verification screenshots linked, so that the discussion happens on the 
mailing list (which is the canonical venue per the [FLIP 
bylaws](https://cwiki.apache.org/confluence/display/FLINK/Flink+Improvement+Proposals)).
   - Once the discussion converges, request a FLIP number and move the draft 
into the official Flink Confluence space.
   - Start the `[VOTE]` thread after the discussion period.
   - Mark this PR as **blocked on FLIP** in the meantime; I'll keep iterating 
on the non-API review feedback you and @spuru9 already left so it stays in good 
shape.
   
   Would you (or any other committer) be willing to be a shepherd / co-author 
for the FLIP? That would help unblock the discussion.
   
   Thanks again!
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to