Samrat002 commented on code in PR #6: URL: https://github.com/apache/flink-connector-redis-streams/pull/6#discussion_r3178574164
########## flink-connector-redis-streams/src/main/java/org/apache/flink/connector/redis/streams/source/reader/RedisStreamsRecordEmitter.java: ########## @@ -0,0 +1,68 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.connector.redis.streams.source.reader; + +import org.apache.flink.annotation.Internal; +import org.apache.flink.api.connector.source.SourceOutput; +import org.apache.flink.connector.base.source.reader.RecordEmitter; +import org.apache.flink.connector.redis.streams.source.RedisStreamsDeserializationSchema; +import org.apache.flink.connector.redis.streams.source.split.RedisStreamsSourceSplitState; + +import io.lettuce.core.StreamMessage; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; + +/** Record emitter that deserializes Redis StreamMessages. */ +@Internal +public class RedisStreamsRecordEmitter<T> Review Comment: This is intentional fail-fast behaviour. If a record cannot be deserialized, rethrowing IOException fails the task. On restart, Flink replays from the last checkpoint, and PEL re-delivers the same entry. If the entry is permanently malformed, the job will restart repeatedly. IMO, the right place to handle this is in the user's `deserialize()` implementation by returning null, it will still be XACKed or catch the error and emit a dead-letter record. The connector itself does not impose a dead-letter or skip policy because those are application-level decisions. I have added Javadoc on RedisStreamsDeserializationSchema now to document this clearly. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
