Samrat002 commented on code in PR #6: URL: https://github.com/apache/flink-connector-redis-streams/pull/6#discussion_r3178589294
########## flink-connector-redis-streams/src/main/java/org/apache/flink/connector/redis/streams/source/RedisStreamsDeserializationSchema.java: ########## @@ -0,0 +1,35 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.connector.redis.streams.source; + +import org.apache.flink.annotation.PublicEvolving; +import org.apache.flink.api.common.typeinfo.TypeInformation; + +import java.io.Serializable; +import java.util.Map; + +/** Converts a Redis Stream entry into a record of type {@code T}. */ +@PublicEvolving +public interface RedisStreamsDeserializationSchema<T> extends Serializable { + + /** Returning {@code null} drops the record (still ACKed). */ + T deserialize(String streamKey, String entryId, Map<String, String> fields) throws Exception; Review Comment: This is required for a more expressive API. Collector<T> enables fan-out splitting a JSON array entry into N records and fan-in filtering emits nothing, `RedisStreamsRecord` decouples the API from the raw Map<String, String>. However, both are breaking changes to the public interface. For now, null = drop covers the filtering case, and fan-out can be done by returning a wrapper type in the schema and flat-mapping in the pipeline. I'd like to revisit the schema API design incrementally, including Collector<T>, open(), and timestamp extraction in a future version rather than making incremental breaking changes. WDUT ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
