davidradl commented on code in PR #28071:
URL: https://github.com/apache/flink/pull/28071#discussion_r3187416024
##########
flink-formats/flink-avro/src/main/java/org/apache/flink/formats/avro/RowDataToAvroConverters.java:
##########
@@ -166,7 +168,11 @@ public Object convert(Schema schema, Object object) {
@Override
public Object convert(Schema schema, Object
object) {
- return ((TimestampData)
object).toInstant().toEpochMilli();
+ final TimestampData timestampData =
(TimestampData) object;
+ if (isMicrosLogicalType(schema)) {
Review Comment:
I agree the the idea here, but am concerned that introducing this behaviour
might result in a regression for existing applications. I wonder if it would be
safer to introduce the new behaviour under a config flag until there is a
version change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
