daguimu commented on code in PR #28071:
URL: https://github.com/apache/flink/pull/28071#discussion_r3201406343
##########
flink-formats/flink-avro/src/main/java/org/apache/flink/formats/avro/RowDataToAvroConverters.java:
##########
@@ -353,4 +370,16 @@ public Object convert(Schema schema, Object object) {
}
};
}
+
+ private static boolean isMicrosLogicalType(Schema schema) {
+ final org.apache.avro.LogicalType logicalType =
schema.getLogicalType();
Review Comment:
Good catch on cleaning up the FQN. Unfortunately
`org.apache.flink.table.types.logical.LogicalType` is already imported on line
28 and used at ~8 sites in this file (e.g. `createConverter(LogicalType type)`
on line 76, `LogicalType[] fieldTypes` on line 282, etc.), so an unqualified
`import org.apache.avro.LogicalType` would collide. Using the FQN at this
single helper-method call site looked less invasive than FQN-ing every Flink
`LogicalType` reference.
Happy to flip it the other way (import the Avro one, FQN the Flink ones) if
you'd prefer — let me know which you'd like to see.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
