davidradl commented on code in PR #39:
URL:
https://github.com/apache/flink-connector-http/pull/39#discussion_r3196426644
##########
flink-connector-http/src/main/java/org/apache/flink/connector/http/table/lookup/HttpTableLookupFunction.java:
##########
@@ -111,13 +117,59 @@ public Collection<RowData> lookup(RowData keyRow) {
physicalArity = physicalRow.getArity();
producedRow =
new GenericRowData(physicalRow.getRowKind(), physicalArity
+ metadataArity);
- // We need to copy in the physical row into the producedRow
+ // Build a map of lookup table field names to their typed values
from keyRow
+ // Only process top-level single-value join keys
+ Map<String, Object> joinKeyValues = new HashMap<>();
Review Comment:
@ferenc-csaky I have done some more testing , prior to Flink 1.20 the
checking was not as rigourous. I have tested the main version again and see the
issue at 1.20; I back ported this change to my local 1.20 and the fix made it
work again. This was a false alarm. Are you ok for this fix to remain in this
PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
