davidradl commented on code in PR #39:
URL:
https://github.com/apache/flink-connector-http/pull/39#discussion_r3200894485
##########
flink-connector-http/src/main/java/org/apache/flink/connector/http/table/lookup/HttpLookupTableSourceFactory.java:
##########
@@ -220,12 +221,16 @@ private HttpLookupConfig getHttpLookupOptions(Context
context, ReadableConfig re
HttpPostRequestCallbackFactory.class,
readableConfig.get(REQUEST_CALLBACK_IDENTIFIER));
+ // Convert ReadableConfig to Configuration for serialization
+ Configuration configuration = new Configuration();
+ readableConfig.toMap().forEach(configuration::setString);
+
return HttpLookupConfig.builder()
.lookupMethod(readableConfig.get(LOOKUP_METHOD))
.url(readableConfig.get(URL))
.useAsync(readableConfig.get(ASYNC_POLLING))
.properties(httpConnectorProperties)
- .readableConfig(readableConfig)
+ .readableConfig(configuration)
Review Comment:
I have implemented this change , but checked whether we already were a
configuration in which case we do not need to do this to and from map.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
