eskabetxe commented on code in PR #180: URL: https://github.com/apache/flink-connector-jdbc/pull/180#discussion_r3237332101
########## flink-connector-jdbc-core/src/main/java/org/apache/flink/connector/jdbc/core/datastream/source/enumerator/splitter/JdbcSqlSplitterEnumerator.java: ########## @@ -0,0 +1,95 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.connector.jdbc.core.datastream.source.enumerator.splitter; + +import org.apache.flink.annotation.Internal; +import org.apache.flink.connector.jdbc.core.datastream.source.enumerator.JdbcSqlSplitEnumeratorBase; +import org.apache.flink.connector.jdbc.core.datastream.source.enumerator.SqlTemplateSplitEnumerator; +import org.apache.flink.connector.jdbc.core.datastream.source.split.JdbcSourceSplit; +import org.apache.flink.connector.jdbc.datasource.connections.JdbcConnectionProvider; + +import java.io.Serializable; +import java.util.ArrayList; +import java.util.List; + +/** + * A splitter enumerator for JdbcSqlSplitEnumeratorBase. + * + * <p>This class is used to allow the retrofit of existing implementations of + * JdbcSqlSplitEnumeratorBase to the new SplitterEnumerator interface. It delegates the split + * enumeration to the underlying JdbcSqlSplitEnumeratorBase instance. + */ +@Deprecated +@Internal +public class JdbcSqlSplitterEnumerator implements SplitterEnumerator { + private final JdbcSqlSplitEnumeratorBase.Provider<?> provider; + private JdbcSqlSplitEnumeratorBase<?> base; + private boolean finished; + + public JdbcSqlSplitterEnumerator(JdbcSqlSplitEnumeratorBase.Provider<?> provider) { + this.provider = provider; + this.base = provider.create(); + this.finished = false; + } + + @Override + public void start(JdbcConnectionProvider connectionProvider) { + base.open(); + } + + @Override + public void close() { + base.close(); + } + + @Override + public boolean isAllSplitsFinished() { + return this.finished; + } + + @Override + public List<JdbcSourceSplit> enumerateSplits() { + try { + this.finished = true; + return base.enumerateSplits(() -> true); + } catch (Exception e) { + throw new RuntimeException("Error enumerating splits", e); + } + } + + @Override + public List<String> lineageQueries() { + List<String> queries = new ArrayList<>(); + if (base instanceof SqlTemplateSplitEnumerator) { + queries.add(((SqlTemplateSplitEnumerator) base).getSqlTemplate()); + } + return queries; + } + + @Override + public Serializable serializableState() { + return null; Review Comment: done -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
