ruanhang1993 commented on code in PR #180: URL: https://github.com/apache/flink-connector-jdbc/pull/180#discussion_r3239473954
########## flink-connector-jdbc-core/src/main/java/org/apache/flink/connector/jdbc/core/datastream/source/enumerator/splitter/SqlSplitterEnumerator.java: ########## @@ -0,0 +1,107 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.connector.jdbc.core.datastream.source.enumerator.splitter; + +import org.apache.flink.annotation.VisibleForTesting; +import org.apache.flink.connector.jdbc.core.datastream.source.split.CheckpointedOffset; +import org.apache.flink.connector.jdbc.core.datastream.source.split.JdbcSourceSplit; +import org.apache.flink.util.Preconditions; + +import java.io.Serializable; +import java.util.ArrayList; +import java.util.Collections; +import java.util.List; +import java.util.Objects; + +/** A sql base template split enumerator. */ +public abstract class SqlSplitterEnumerator implements SplitterEnumerator { + + private final char[] currentId = "0000000000".toCharArray(); + + private final String sqlTemplate; + + protected SqlSplitterEnumerator(String sqlTemplate) { + this.sqlTemplate = Preconditions.checkNotNull(sqlTemplate); + } + + @VisibleForTesting + protected abstract Serializable[][] getSqlParameters(); + + protected String getSqlTemplate() { + return this.sqlTemplate; + } + + @Override + public List<JdbcSourceSplit> enumerateSplits() { + Serializable[][] params = getSqlParameters(); + int paramLength = params.length; + List<JdbcSourceSplit> splitList = new ArrayList<>(paramLength); + if (paramLength == 0) { + splitList.add(createSplit(null)); Review Comment: There is a different behavior in the new enumerator. For the old enumerator `SqlTemplateSplitEnumerator`: - When the `paramLength` is 0 in `SqlTemplateSplitEnumerator#enumerateSplits`, it will return an empty list. - When the `params` is null in `SqlTemplateSplitEnumerator#enumerateSplits`, it will return a jdbc split with the null param. For the new enumerator `SqlSplitterEnumerator`: - When the `paramLength` is 0 in `SqlSplitterEnumerator#enumerateSplits`, it will return a jdbc split with the null param. When the next split is not available,`SlideTimingSplitterEnumerator#getSqlParameters` will return an empty params , which will cause that it will return a jdbc split with the null param. The jdbc split with a null param will throw an exception in `prepareStatement`. So the job will fail for this. WDYT? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
