JinkunLiu commented on PR #599: URL: https://github.com/apache/flink-agents/pull/599#issuecomment-4473999308
Thanks for the review! @xintongsong 1. Fixed the extra `--` issue. On whether to make gum required — I referenced openclaw's design, which treats it as an optional dependency rather than a hard requirement. Since gum is just a UI enhancement and not something the script needs to work, I think keeping it optional makes more sense. 2. Added a download progress indicator for the Flink binary. Done. 3. I aware the pip install output is noisy, but haven't found a elegant solution yet. Open to suggestions if you have ideas. 4. I couldn't reproduce the double-slash issue in `FLINK_HOME`. Could you share more details about how it was triggered? 5. Improved path input validation so users get a second chance on wrong Flink path input. As for going back after reviewing the plan — since the number of configuration fields is still relatively small, I considering leaving that out for now. WDYT? 6. The `Ctrl+C` issue has been fixed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
