wenjin272 commented on PR #599:
URL: https://github.com/apache/flink-agents/pull/599#issuecomment-4499073502
Hi, @JinkunLiu @xintongsong, I have made some additional updates to this PR,
which address the following issues. PTAL
- **`flink-agents` JAR missing when PyFlink skipped** — download JAR
directly from ASF mirror (SHA512-verified); Python no longer required for Java
users.
- **Existing Flink version not detected** — parse `lib/flink-dist-*.jar`,
fall back to `bin/flink --version` with a progress hint.
- **"Install dir" / version shown even when not installing** — plan split
into read-only **Environment** + editable **Plan**; install-only rows hidden on
`INSTALL_FLINK=No`.
- **Toggling `Install Flink` didn't re-prompt** — `No → Yes` now cascades
into version + dir prompts.
- **`JAVA_HOME` looked editable** — moved to read-only Environment section.
- **No Tab-completion on paths** — `read -e -r -p` replaces `gum input`.
- **`export FLINK_HOME=…` line unclear** — numbered **Next steps** block
with rationale.
- **Double slashes / `~` / trailing `/` in paths** — `normalize_path`
helper wired into every path entry.
- **Ctrl+C swallowed** — global `trap die_cancelled INT`; stderr cancel
msg; `confirm` honors subshell exit code.
- **ESC quit installer / no way back** — edit menu wrapped in `( )`
subshell, ESC backs out at any nesting depth.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
