davidradl commented on code in PR #28216: URL: https://github.com/apache/flink/pull/28216#discussion_r3279670256
########## flink-python/pyflink/datastream/functions.py: ########## @@ -19,7 +19,7 @@ from enum import Enum from py4j.java_gateway import JavaObject -from typing import Union, Any, Generic, TypeVar, Iterable, List, Callable, Optional +from typing import Union, Any, Generic, TypeVar, Iterable, Iterator, List, Callable, Optional Review Comment: - is there a migration consideration with these changes? - I am curious whether that can be tested maybe by having tests implementing the generic types. - in terms of the PR title - the title should be either a square bracketed JIRA number or start with [hotfix]. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
