Vaibhav-S-Gowda commented on code in PR #28216: URL: https://github.com/apache/flink/pull/28216#discussion_r3282214344
########## flink-python/pyflink/datastream/functions.py: ########## @@ -19,7 +19,7 @@ from enum import Enum from py4j.java_gateway import JavaObject -from typing import Union, Any, Generic, TypeVar, Iterable, List, Callable, Optional +from typing import Union, Any, Generic, TypeVar, Iterable, Iterator, List, Callable, Optional Review Comment: Hi @davidradl, thanks for the feedback! - These changes are backward compatible since Python generics aren't enforced at runtime, so existing subclasses won't be affected. - I'll add tests that implement the generic types as you suggested. - Will also create a JIRA ticket and fix the PR title. Updates coming soon! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
