wenjin272 commented on code in PR #831:
URL: https://github.com/apache/flink-agents/pull/831#discussion_r3386766768
##########
python/flink_agents/integrations/embedding_models/local/tests/test_ollama_embedding_model.py:
##########
@@ -34,14 +31,8 @@
pytestmark = pytest.mark.integration
test_model = os.environ.get("OLLAMA_EMBEDDING_MODEL", "all-minilm:22m")
-current_dir = Path(__file__).parent
try:
- # only auto setup ollama in ci with python 3.10 to reduce ci cost.
- if "3.10" in sys.version:
- subprocess.run(
- ["bash", f"{current_dir}/start_ollama_server.sh"], timeout=300,
check=True
- )
Review Comment:
ditto
##########
python/flink_agents/integrations/chat_models/tests/test_ollama_chat_model.py:
##########
@@ -37,16 +34,8 @@
pytestmark = pytest.mark.integration
test_model = os.environ.get("OLLAMA_CHAT_MODEL", "qwen3:1.7b")
-current_dir = Path(__file__).parent
try:
- # only auto setup ollama in ci with python 3.10 to reduce ci cost.
- if "3.10" in sys.version:
- subprocess.run(
- ["bash", f"{current_dir}/start_ollama_server.sh", test_model],
- timeout=300,
- check=True,
- )
Review Comment:
The script `start_ollama_server.sh` installs the Ollama server and pulls the
required models. After moving the integration tests into the `it-python`
pipeline, we no longer need to install the Ollama server separately; however,
we still need to pull the test models being used. We can use the `pull_model`
method in `test_utils.py`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
