rosemarYuan commented on code in PR #756:
URL: https://github.com/apache/flink-agents/pull/756#discussion_r3394016303
##########
api/src/main/java/org/apache/flink/agents/api/annotation/Action.java:
##########
@@ -59,12 +60,8 @@
@Target(ElementType.METHOD)
@Retention(RetentionPolicy.RUNTIME)
public @interface Action {
- /**
- * List of event type strings that this action should respond to.
- *
- * @return Array of event type strings
- */
- String[] listenEventTypes();
+ /** Event type name strings; multiple entries have OR semantics. */
+ String[] value();
Review Comment:
Good point — added a one-sentence note on explaining:
- (1) The JLS §9.7.3 reason for the name.
- (2) Its mapping to Python's `*trigger_conditions`.
Kept it tight to avoid bloating the annotation javadoc.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
