rosemarYuan commented on PR #756:
URL: https://github.com/apache/flink-agents/pull/756#issuecomment-4678184138
Hi @xintongsong, need a policy call from you.
This PR renames `listen_event_types` -> `trigger_conditions`. I added a
fallback on both Java (`ActionJsonDeserializer`) and Python
(`Action.model_validator`), so old plan JSON still deserializes.
@wenjin272 pointed out we're still in 0.x and don't owe API/state
compatibility yet (#631 already broke API in 0.3), so the fallback may be debt
we shouldn't take on until the 0.4 / 1.0 commitment.
That policy angle wasn't on the table in the earlier review — we only
discussed whether the fallback was correctly implemented. Could you decide:
(A) keep the fallback + tests, or
(B) drop them under the 0.x "no compat" stance?
Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
