spuru9 opened a new pull request, #28496: URL: https://github.com/apache/flink/pull/28496
## What is the purpose of the change Migrate the remaining JUnit 4 tests in `flink-examples/flink-examples-streaming` to JUnit 5 (Jupiter). After this PR the module has zero JUnit 4 imports. Part of the umbrella JUnit 4 → 5 migration. JIRA: [FLINK-39769](https://issues.apache.org/jira/browse/FLINK-39769) (sub-task of [FLINK-25325](https://issues.apache.org/jira/browse/FLINK-25325)) ## Brief change log Three test classes migrated: - **`StreamingExamplesITCase`** and **`SocketWindowWordCountITCase`** (parameterized): - `@RunWith(Parameterized.class)` → `@ExtendWith(ParameterizedTestExtension.class)`. - `@Parameterized.Parameter` → `@Parameter`; `@Parameterized.Parameters` → `@Parameters(name = ...)`. - `@Test` → `@TestTemplate` (required for the parameterized extension). - `extends AbstractTestBaseJUnit4` → `extends AbstractTestBase` (the JUnit 5 sibling). - `org.junit.Assert.fail` → `org.assertj.core.api.Assertions.fail` (`SocketWindowWordCountITCase`). - **`TopSpeedWindowingExampleITCase`**: - `@ClassRule MiniClusterWithClientResource` → `@RegisterExtension static MiniClusterExtension`. - `@ClassRule TemporaryFolder` → `@TempDir static File`; `newFile()`/`newFolder()` → `new File(tempDir, ...)`. - Drop `extends TestLogger`; `org.junit.Test` → `org.junit.jupiter.api.Test`. - Drop `public` on test classes and methods per the Flink JUnit 5 Migration Guide. No production code is touched. ## Verifying this change This change is a test-only migration covered by the existing tests it migrates: ``` ./mvnw -pl flink-examples/flink-examples-streaming test \ -Dtest='StreamingExamplesITCase,TopSpeedWindowingExampleITCase,SocketWindowWordCountITCase' ``` Result: **11 tests run, 0 failures, 0 errors, 0 skipped** (`StreamingExamplesITCase` 8, `SocketWindowWordCountITCase` 2, `TopSpeedWindowingExampleITCase` 1), matching the pre-migration baseline. ## Does this pull request potentially affect one of the following parts: - Dependencies (does it add or upgrade a dependency): (no) - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no) - The serializers: (no) - The runtime per-record code paths (performance sensitive): (no) - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (no) - The S3 file system connector: (no) ## Documentation - Does this pull request introduce a new feature? (no) - If yes, how is the feature documented? (not applicable) --- ##### Was generative AI tooling used to co-author this PR? - [x] Yes — Claude Code -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
