snuyanzin commented on code in PR #28496:
URL: https://github.com/apache/flink/pull/28496#discussion_r3454261420
##########
flink-examples/flink-examples-streaming/src/test/java/org/apache/flink/streaming/test/socket/SocketWindowWordCountITCase.java:
##########
@@ -35,24 +37,23 @@
import java.net.InetAddress;
import java.net.ServerSocket;
import java.net.Socket;
-import java.util.Arrays;
-import java.util.Collection;
+import java.util.List;
-import static org.junit.Assert.fail;
+import static org.assertj.core.api.Assertions.fail;
/** Tests for {@link SocketWindowWordCount}. */
-@RunWith(Parameterized.class)
-public class SocketWindowWordCountITCase extends AbstractTestBaseJUnit4 {
+@ExtendWith(ParameterizedTestExtension.class)
+class SocketWindowWordCountITCase extends AbstractTestBase {
- @Parameterized.Parameter public boolean asyncState;
+ @Parameter private boolean asyncState;
- @Parameterized.Parameters
- public static Collection<Boolean> setup() {
- return Arrays.asList(false, true);
+ @Parameters(name = "asyncState: {0}")
+ public static List<Boolean> parameters() {
+ return List.of(false, true);
}
Review Comment:
why do we need it?
can we just use
```java
@ParameterizedTest
@Values(true, false)
```
?
same for others
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
