spuru9 commented on code in PR #28481:
URL: https://github.com/apache/flink/pull/28481#discussion_r3447869260
##########
flink-runtime/src/test/java/org/apache/flink/runtime/scheduler/adaptivebatch/AdaptiveBatchSchedulerTest.java:
##########
@@ -107,54 +103,10 @@ void setUp() {
// failures (FLINK-38970) caused by main thread constraint violations
when
// CompletableFuture callbacks are dispatched from background IO
executor threads.
// The synchronous execution is preserved while eliminating the race
condition.
Review Comment:
Refers to the old executer in some way. Can be shortened to match the change.
```suggestion
// No-op thread check avoids flakiness from FLINK-38970: scheduler callbacks
// can complete on background IO threads rather than the main thread.
```
##########
flink-runtime/src/test/java/org/apache/flink/runtime/scheduler/adaptivebatch/AdaptiveBatchSchedulerTest.java:
##########
@@ -87,7 +83,7 @@
import static org.assertj.core.api.Assertions.assertThat;
/** Test for {@link AdaptiveBatchScheduler}. */
-class AdaptiveBatchSchedulerTest {
+public class AdaptiveBatchSchedulerTest {
Review Comment:
Why make the class public? JUnit 5 doesn't need it, and the convention here
is to keep test classes package-private.
```suggestion
class AdaptiveBatchSchedulerTest {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
