spuru9 commented on code in PR #28481:
URL: https://github.com/apache/flink/pull/28481#discussion_r3448104481
##########
flink-runtime/src/test/java/org/apache/flink/runtime/scheduler/adaptivebatch/AdaptiveBatchSchedulerTest.java:
##########
@@ -106,55 +102,12 @@ void setUp() {
// execution semantics without strict thread identity checks. This
fixes flaky test
// failures (FLINK-38970) caused by main thread constraint violations
when
// CompletableFuture callbacks are dispatched from background IO
executor threads.
- // The synchronous execution is preserved while eliminating the race
condition.
- mainThreadExecutor = new SynchronousComponentMainThreadExecutor();
+// No-op thread check avoids flakiness from FLINK-38970: scheduler callbacks
Review Comment:
@ocb3916 I think the suggestion didnt work as intended, might have to do
locally.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]