snuyanzin commented on code in PR #28290:
URL: https://github.com/apache/flink/pull/28290#discussion_r3448678169


##########
flink-table/flink-table-planner/src/main/java/org/apache/calcite/sql/type/BasicSqlType.java:
##########
@@ -144,7 +144,7 @@ protected static void checkPrecScale(
     // ~ Methods 
----------------------------------------------------------------
 
     /** Constructs a type with nullablity. */
-    BasicSqlType createWithNullability(boolean nullable) {
+    public BasicSqlType createWithNullability(boolean nullable) {

Review Comment:
   sync with Calcite



##########
flink-table/flink-table-planner/src/main/java/org/apache/calcite/sql/type/SqlTypeAssignmentRule.java:
##########
@@ -14,7 +14,6 @@
  * See the License for the specific language governing permissions and
  * limitations under the License.
  */
-
 package org.apache.calcite.sql.type;

Review Comment:
   sync with Calcite



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to