snuyanzin commented on code in PR #28290:
URL: https://github.com/apache/flink/pull/28290#discussion_r3452016703
##########
flink-table/flink-table-planner/src/test/resources/org/apache/flink/table/planner/plan/batch/sql/DynamicFunctionPlanTest.xml:
##########
@@ -34,10 +34,11 @@ LogicalAggregate(group=[{0, 1}], EXPR$2=[SUM($2)],
EXPR$3=[COUNT()])
</Resource>
<Resource name="optimized exec plan">
<![CDATA[
-HashAggregate(isMerge=[false], groupBy=[cat], auxGrouping=[gmt_date],
select=[cat, gmt_date, SUM(cnt) AS EXPR$2, COUNT(*) AS EXPR$3])
-+- Exchange(distribution=[hash[cat]])
- +- Calc(select=[cat, gmt_date, cnt], where=[(gmt_date = CURRENT_DATE())])
- +- TableSourceScan(table=[[default_catalog, default_database, src,
filter=[], project=[cat, gmt_date, cnt], metadata=[]]], fields=[cat, gmt_date,
cnt])
+Calc(select=[cat, CAST(CURRENT_DATE() AS DATE) AS gmt_date, EXPR$2, EXPR$3])
Review Comment:
This is test for batch
we have these kind of tests running both for batch and stream both extending
`DynamicFunctionPlanTestBase`
(https://github.com/snuyanzin/flink/blob/6aadeddbc5ede604c95be2d6fea2557e49ae5330/flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/plan/common/DynamicFunctionPlanTestBase.java)
like for batch
https://github.com/snuyanzin/flink/blob/6aadeddbc5ede604c95be2d6fea2557e49ae5330/flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/plan/batch/sql/DynamicFunctionPlanTest.java
and for stream
https://github.com/snuyanzin/flink/blob/6aadeddbc5ede604c95be2d6fea2557e49ae5330/flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/plan/stream/sql/DynamicFunctionPlanTest.java
the plan for stream is unchanged in this PR
https://github.com/snuyanzin/flink/blob/6aadeddbc5ede604c95be2d6fea2557e49ae5330/flink-table/flink-table-planner/src/test/resources/org/apache/flink/table/planner/plan/stream/sql/DynamicFunctionPlanTest.xml#L19-L41
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
