spuru9 commented on code in PR #28529:
URL: https://github.com/apache/flink/pull/28529#discussion_r3471654331
##########
flink-table/flink-sql-gateway/src/main/java/org/apache/flink/table/gateway/service/context/SessionContext.java:
##########
@@ -318,6 +320,21 @@ public static SessionContext create(
new OperationManager(operationExecutorService));
}
+ private static URL[] getDependencyURLs(DefaultContext defaultContext) {
+ return defaultContext.getDependencies().stream()
+ .map(SessionContext::toURL)
+ .toArray(URL[]::new);
+ }
+
+ private static URL toURL(URI uri) {
+ try {
+ return uri.toURL();
+ } catch (MalformedURLException e) {
Review Comment:
nit: `--jar` takes a plain path, and `toURL()` throws
`IllegalArgumentException` ("URI is not absolute") on a schemeless URI, not
`MalformedURLException` — so a path-based jar slips past this catch and
surfaces raw instead of the friendly message. Mind folding it in?
```suggestion
} catch (MalformedURLException | IllegalArgumentException e) {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
