spuru9 commented on code in PR #28529:
URL: https://github.com/apache/flink/pull/28529#discussion_r3471654331
##########
flink-table/flink-sql-gateway/src/main/java/org/apache/flink/table/gateway/service/context/SessionContext.java:
##########
@@ -318,6 +320,21 @@ public static SessionContext create(
new OperationManager(operationExecutorService));
}
+ private static URL[] getDependencyURLs(DefaultContext defaultContext) {
+ return defaultContext.getDependencies().stream()
+ .map(SessionContext::toURL)
+ .toArray(URL[]::new);
+ }
+
+ private static URL toURL(URI uri) {
+ try {
+ return uri.toURL();
+ } catch (MalformedURLException e) {
Review Comment:
nit: a plain `--jar foo.jar` is a schemeless URI, so `toURL()` throws
`IllegalArgumentException`, not `MalformedURLException` — dodges this catch.
Add it?
```suggestion
} catch (MalformedURLException | IllegalArgumentException e) {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
