davidradl commented on code in PR #28594:
URL: https://github.com/apache/flink/pull/28594#discussion_r3506040967
##########
flink-formats/flink-csv/src/main/java/org/apache/flink/formats/csv/CsvFormatOptions.java:
##########
@@ -139,5 +139,14 @@ public class CsvFormatOptions {
+ "(disabled by default). "
+ "Only affects deserialization.");
+ public static final ConfigOption<Boolean> IGNORE_FIRST_LINE =
+ ConfigOptions.key("ignore-first-line")
+ .booleanType()
+ .defaultValue(false)
+ .withDescription(
+ "Optional flag to skip the first CSV record of
each file "
+ + "(disabled by default). "
Review Comment:
I suggest sasing false by default, rather than disabled. so you do avoid
implied double negative sentences like disable ignore.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
