Vishal-Kamlapure commented on code in PR #28594:
URL: https://github.com/apache/flink/pull/28594#discussion_r3507970700
##########
docs/content/docs/connectors/table/formats/csv.md:
##########
@@ -200,6 +200,14 @@ Format Options
<td>Boolean</td>
<td>Optional flag to treat empty string values as null (disabled by
default). Only affects deserialization.</td>
</tr>
+ <tr>
+ <td><h5>csv.ignore-first-line</h5></td>
+ <td>optional</td>
+ <td>no</td>
+ <td style="word-wrap: break-word;">false</td>
+ <td>Boolean</td>
+ <td>Optional flag to skip the first CSV record of each file during
deserialization (disabled by default). Only supported by the filesystem
connector. The table schema is not derived from the skipped record. Only
affects deserialization.</td>
Review Comment:
Hi @davidradl , thanks for the review!
Regarding the phrase 'Only affects deserialization' — practically, for the
user, it means this option only applies when reading data (Source) and is
ignored if applied to a Sink.
I noticed 'Only affects deserialization' is the standard phrasing used by
all other read-only options in this file (e.g., `csv.trim-spaces`). To keep
this PR tightly scoped and maintain consistency across the table, my plan is to
keep that specific phrasing intact at the very end of the description. (If we
want to change it to something more user-friendly like 'Only applies when
reading data', a separate docs cleanup PR for all of those options might be
best).
Let me know if you are okay with keeping it for consistency!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
