bharathgunapati opened a new pull request, #53:
URL: https://github.com/apache/flink-connector-http/pull/53
## What is the purpose of the change
The HTTP lookup option for sync vs async polling is the only camelCase table
option in the connector (`asyncPolling`). All other options use kebab-case or
dotted keys (e.g. `lookup-method`, `http.source.lookup.request.timeout`).
This renames the canonical key to `async-polling` to align with Flink
connector
naming conventions. The legacy `asyncPolling` key remains supported via
`withDeprecatedKeys` so existing DDL does not need to change.
No runtime behavior change: default remains `false`, and the option is
already
read via `ReadableConfig.get(ASYNC_POLLING)`.
## Brief change log
- `HttpLookupConnectorOptions.ASYNC_POLLING`: canonical key `async-polling`,
deprecated alias `asyncPolling`, description updated.
- Docs (en + zh): option table and examples updated to `async-polling`.
- Tests: parameterized factory and runtime tests cover both canonical and
deprecated keys; ITCases updated to canonical key (mechanical).
## Compatibility note
- **Canonical key:** `async-polling`
- **Legacy key:** `asyncPolling` still works via `withDeprecatedKeys`
- **Default:** `false` (unchanged)
- **Migration:** optional — existing DDL using `asyncPolling` continues to
work;
new configurations should use `async-polling`
Release note is on
[FLINK-40149](https://issues.apache.org/jira/browse/FLINK-40149).
## Verifying this change
CI green on fork (Flink 2.2.0, JDK 11/17/21):
https://github.com/bharathgunapati/flink-connector-http/actions/runs/29353591657
Automated tests:
- `HttpLookupTableSourceFactoryTest#shouldAcceptAsyncPollingAtFactory` —
factory
accepts both `async-polling` and `asyncPolling`
-
`HttpLookupTableSourceTest#shouldCreateAsyncTableSourceWithAsyncPollingKey` —
runtime async path for both keys
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): **no**
- The public API, i.e., is any changed class annotated with
`@Public(Evolving)`: **no**
- The serializers: **no**
- The runtime per-record code paths (performance sensitive): **no**
- Anything that affects deployment or recovery: **no**
## Documentation
- Does this pull request introduce a new feature? **no** (consistency
improvement)
- If yes, how is the feature documented? docs updated (en + zh)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
