bharathgunapati commented on PR #53: URL: https://github.com/apache/flink-connector-http/pull/53#issuecomment-5033482246
@davidradl — thanks for the follow-up review. I’ve addressed the three comments in 37a4f22: Removed the 1-arg validateHttpLookupSourceOptions overload — only the 2-arg signature remains, so there’s no subclass override hazard. Documented the deprecated-key WARN — Javadoc on DEPRECATED_ASYNC_POLLING_KEY notes that Flink’s withDeprecatedKeys emits a WARN at runtime and that this is intentional. Tightened the docs wording (en + zh) — asyncPolling now reads: Deprecated. Use async-polling instead. Setting both keys in the same DDL is a validation error. Would you mind taking another look when you have a moment? Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
