snuyanzin commented on code in PR #28758:
URL: https://github.com/apache/flink/pull/28758#discussion_r3610327513
##########
flink-core/src/test/java/org/apache/flink/types/variant/BinaryVariantInternalBuilderTest.java:
##########
@@ -120,6 +122,15 @@ void testParseJsonObject() throws IOException {
assertThat(variant.getField("k2").getDecimal()).isEqualTo(BigDecimal.valueOf(1.5));
}
+ @ParameterizedTest
+ @ValueSource(strings = {"NaN", "Infinity", "-Infinity"})
+ void testParseJsonRejectsNonNumericNumbers(final String nonNumericNumber) {
+ // NaN and the infinities are not valid JSON, so parsing fails:
PARSE_JSON surfaces the
+ // error and TRY_PARSE_JSON returns NULL.
Review Comment:
then the question: why do we support these values in some parts of the code
and do not support in others?
Do we have a plan to be consistent for all parts?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
