raminqaf commented on code in PR #28758:
URL: https://github.com/apache/flink/pull/28758#discussion_r3614482042
##########
flink-core/src/test/java/org/apache/flink/types/variant/BinaryVariantInternalBuilderTest.java:
##########
@@ -120,6 +122,15 @@ void testParseJsonObject() throws IOException {
assertThat(variant.getField("k2").getDecimal()).isEqualTo(BigDecimal.valueOf(1.5));
}
+ @ParameterizedTest
+ @ValueSource(strings = {"NaN", "Infinity", "-Infinity"})
+ void testParseJsonRejectsNonNumericNumbers(final String nonNumericNumber) {
+ // NaN and the infinities are not valid JSON, so parsing fails:
PARSE_JSON surfaces the
+ // error and TRY_PARSE_JSON returns NULL.
Review Comment:
In Variant we don't and I don't think we should because it follows the JSON
spec. Vendors like Snowflake and Databricks also don't allow it.
For cast we do `CAST('Nan' AS FLOAT)` and it is a valid case
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
