riyarawat-amazon opened a new pull request, #252:
URL: https://github.com/apache/flink-connector-aws/pull/252

   ## What is the purpose of the change
   
   Removes the redundant DescribeStream inconsistency-resolution check from the 
DynamoDB Streams source enumerator. The check added extra `DescribeStream` 
calls and could discard an entire discovery cycle, stalling progress.
   
   The enumerator previously detected "closed leaf, no child" inconsistencies 
in `DescribeStream` output and retried with `exclusiveStartShardId` up to 5 
times; if unresolved it returned an empty shard list and early-returned. This 
is redundant: discovery runs periodically (every 60s) so a transiently-missing 
child shard is picked up on a subsequent cycle, and parent-before-child 
ordering is already enforced at assignment time by the parent-finished/absent 
gate in `SplitTracker`.
   
   JIRA: https://issues.apache.org/jira/browse/FLINK-40184
   
   ## Brief change log
   
   - `DynamoDbStreamsSourceEnumerator`: drop the `inconsistencyDetected` 
early-return in `processDiscoveredSplits`, delete 
`trackSplitsAndResolveInconsistencies`, and simplify `discoverSplits` to 
`return streamProxy.listShards(streamArn, null)`
   - Delete `SplitGraphInconsistencyTracker` (+ test)
   - Remove `ListShardsResult.inconsistencyDetected` (+ test)
   - Remove the `DESCRIBE_STREAM_INCONSISTENCY_RESOLUTION_RETRY_COUNT` config 
option
   - Remove `ShardUtils.isShardOlderThanInconsistencyDetectionRetentionPeriod` 
(+ its 25h retention constant, + test)
   
   ## Verifying this change
   
   This change is covered by existing enumerator and split-tracker tests; only 
the tests covering the deleted code were removed. Existing tests pass.
   
   ## Does this pull request potentially affect one of the following parts:
   
   - Dependencies (does it add or upgrade a dependency): **no**
   - The public API, i.e., is any changed class annotated with 
`@Public(Evolving)`: **no** (removes an internal config option only)
   - The serializers: **no**
   - The runtime per-record code paths (performance sensitive): **no**
   - Anything that affects deployment or recovery: **no**
   - The S3 file system connector: **no**
   
   ## Documentation
   
   - Does this pull request introduce a new feature? **no**
   - If yes, how is the feature documented? not applicable
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to