ferenc-csaky commented on code in PR #252:
URL:
https://github.com/apache/flink-connector-aws/pull/252#discussion_r3614696446
##########
flink-connector-aws/flink-connector-dynamodb/src/main/java/org/apache/flink/connector/dynamodb/source/config/DynamodbStreamsSourceConfigConstants.java:
##########
@@ -45,13 +45,6 @@ public enum InitialPosition {
.defaultValue(Duration.ofSeconds(60))
.withDescription("The interval between each attempt to
discover new shards.");
- public static final ConfigOption<Integer>
DESCRIBE_STREAM_INCONSISTENCY_RESOLUTION_RETRY_COUNT =
Review Comment:
Removing this is backward-compatible, right? So if someone explicitly
overridden this config in their `config.yaml`, after this gets release, this
simply gets ignored instead of an invalid config, correct?
Based on the change, it seems like that to me, but I wanna double-check to
be sure, cause otherwise we must deprecate instead of remove to be able to
release this in a minor version.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
