Savonitar commented on code in PR #279:
URL:
https://github.com/apache/flink-connector-kafka/pull/279#discussion_r3648273620
##########
flink-connector-kafka/src/main/java/org/apache/flink/connector/kafka/dynamic/source/enumerator/DynamicKafkaSourceEnumerator.java:
##########
@@ -77,6 +80,7 @@
@Internal
public class DynamicKafkaSourceEnumerator
implements SplitEnumerator<DynamicKafkaSourceSplit,
DynamicKafkaSourceEnumState> {
+ private static final long RETAINED_SPLIT_OFFSET_HANDOFF_MIN_TIMEOUT_MS =
60_000L;
Review Comment:
should it be configurable?
##########
flink-connector-kafka/src/test/java/org/apache/flink/connector/kafka/dynamic/source/enumerator/DynamicKafkaSourceEnumeratorTest.java:
##########
@@ -714,7 +716,12 @@ public void
testEnumeratorStateRetainsRemovedClusterUntilExpired() throws Throwa
DynamicKafkaSourceOptions
.STREAM_METADATA_REMOVED_CLUSTER_RETENTION_MS
.key(),
- "1000");
+ "60000");
+ properties.setProperty(
+
DynamicKafkaSourceOptions.STREAM_ENUMERATOR_MODE.key(),
+
DynamicKafkaSourceOptions.EnumeratorMode.GLOBAL
Review Comment:
Is my understanding correct that this test previously ran in the **default**
enumerator mode and is now switched to `GLOBAL`? If so, and given that all the
other new handoff tests also set `GLOBAL`, does that leave the default mode
without any coverage of the new handoff path, and does this test lose the
`PER_CLUSTER` coverage it used to provide?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
