lnbest0707 commented on code in PR #279:
URL:
https://github.com/apache/flink-connector-kafka/pull/279#discussion_r3661400959
##########
flink-connector-kafka/src/test/java/org/apache/flink/connector/kafka/dynamic/source/enumerator/DynamicKafkaSourceEnumeratorTest.java:
##########
@@ -714,7 +716,12 @@ public void
testEnumeratorStateRetainsRemovedClusterUntilExpired() throws Throwa
DynamicKafkaSourceOptions
.STREAM_METADATA_REMOVED_CLUSTER_RETENTION_MS
.key(),
- "1000");
+ "60000");
+ properties.setProperty(
+
DynamicKafkaSourceOptions.STREAM_ENUMERATOR_MODE.key(),
+
DynamicKafkaSourceOptions.EnumeratorMode.GLOBAL
Review Comment:
Good catch—addressed in 4dd586a0. The existing retained-cluster recovery
test is now parameterized over both enumerator modes. For `PER_CLUSTER`, the
mode property is intentionally left unset in both the initial and restored
enumerators, so the test exercises the actual default. For `GLOBAL`, it
preserves the global-only fresh-reader assignment assertion. The complete
enumerator test suite passes: 33 tests, 0 failures.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
