RocMarshal commented on code in PR #28500:
URL: https://github.com/apache/flink/pull/28500#discussion_r3733491202
##########
flink-table/flink-table-api-scala-bridge/src/main/scala/org/apache/flink/table/api/bridge/scala/StreamTableEnvironment.scala:
##########
@@ -833,7 +835,13 @@ object StreamTableEnvironment {
* The Scala [[StreamExecutionEnvironment]] of the [[TableEnvironment]].
*/
def create(executionEnvironment: StreamExecutionEnvironment):
StreamTableEnvironment = {
- create(executionEnvironment, EnvironmentSettings.newInstance().build)
+ val runtimeMode =
+ if
(executionEnvironment.getConfiguration.get(ExecutionOptions.RUNTIME_MODE) ==
Review Comment:
Will this value ever be explicitly set to null?
This key has a default value. If upstream won’t actively set it to null, is
there any risk in just passing the value straight from the config into the
Builder?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
