argoyal2212 commented on code in PR #28500:
URL: https://github.com/apache/flink/pull/28500#discussion_r3733516259
##########
flink-table/flink-table-api-scala-bridge/src/main/scala/org/apache/flink/table/api/bridge/scala/StreamTableEnvironment.scala:
##########
@@ -833,7 +835,13 @@ object StreamTableEnvironment {
* The Scala [[StreamExecutionEnvironment]] of the [[TableEnvironment]].
*/
def create(executionEnvironment: StreamExecutionEnvironment):
StreamTableEnvironment = {
- create(executionEnvironment, EnvironmentSettings.newInstance().build)
+ val runtimeMode =
+ if
(executionEnvironment.getConfiguration.get(ExecutionOptions.RUNTIME_MODE) ==
Review Comment:
It is never null. The reason for the check is `RuntimeExecutionMode` also
has an `AUTOMATIC` value. Before this PR, only `BATCH` triggered `inBatchMode`,
so `AUTOMATIC` always defaulted to `STREAMING`. Passing the config value
straight through would let `AUTOMATIC` flip `isStreamingMode` to false, which
changes existing behavior. Proposed changes just keeps `AUTOMATIC` mapped to
`STREAMING` like before.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
