twalthr commented on code in PR #28930:
URL: https://github.com/apache/flink/pull/28930#discussion_r3767100962
##########
flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/plan/nodes/exec/common/CommonExecSink.java:
##########
@@ -199,10 +209,10 @@ protected Transformation<Object> createSinkTransformation(
primaryKeys,
sinkParallelism,
inputParallelism,
- upsertMaterialize);
+ needMaterialization);
}
- if (upsertMaterialize) {
+ if (needMaterialization) {
Review Comment:
Unlikely, not many users use FORCE and not many users have updated to 2.3.0.
This is clearly a regression and should be fixed for 2.3.1.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
