gustavodemorais commented on code in PR #28930:
URL: https://github.com/apache/flink/pull/28930#discussion_r3767144668
##########
flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/plan/nodes/exec/common/CommonExecSink.java:
##########
@@ -199,10 +209,10 @@ protected Transformation<Object> createSinkTransformation(
primaryKeys,
sinkParallelism,
inputParallelism,
- upsertMaterialize);
+ needMaterialization);
}
- if (upsertMaterialize) {
+ if (needMaterialization) {
Review Comment:
You're right that this could be an issue. It's unfortunately a regression
that will either affect these jobs or all future jobs that eventually migrate
from 1.x or 2.x to 2.3.x. We probably want to prioritize the latter
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
