VasShabu commented on code in PR #28850: URL: https://github.com/apache/flink/pull/28850#discussion_r3767296384
########## flink-table/flink-table-common/src/main/java/org/apache/flink/table/types/inference/strategies/JsonPathInputTypeStrategy.java: ########## @@ -0,0 +1,84 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.table.types.inference.strategies; + +import org.apache.flink.annotation.Internal; +import org.apache.flink.table.functions.FunctionDefinition; +import org.apache.flink.table.types.DataType; +import org.apache.flink.table.types.inference.ArgumentCount; +import org.apache.flink.table.types.inference.CallContext; +import org.apache.flink.table.types.inference.InputTypeStrategy; +import org.apache.flink.table.types.inference.Signature; + +import java.util.List; +import java.util.Optional; +import java.util.regex.Pattern; + +/** + * Strategy for a JSON function whose optional second argument is a path literal. Rejects the {@code + * lax}/{@code strict} path mode prefix at planning time and delegates everything else to {@code + * signatures}. + */ +@Internal +public final class JsonPathInputTypeStrategy implements InputTypeStrategy { + + private static final int ARG_PATH = 1; + + private static final Pattern PATH_MODE_PREFIX = + Pattern.compile("\\s*(strict|lax)\\s+.+", Pattern.CASE_INSENSITIVE | Pattern.DOTALL); + Review Comment: I tested with jsonValue for this input ,`SELECT json_type('{"strict value":"my value"}', 'strict value');` rather than `SELECT json_type('{"strict value":"my value"}', "strict value");` due to invalid syntax, and this produced the same result as json_type. I initially thought this was due to the space but i had a look at this example with json_type and json_value and the test worked fine <img width="510" height="421" alt="image" src="https://github.com/user-attachments/assets/0a9df944-9293-44ab-bcfa-c1997cd97a2f"; /> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
