gustavodemorais commented on code in PR #28850:
URL: https://github.com/apache/flink/pull/28850#discussion_r3774788882
##########
flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/functions/JsonFunctionsITCase.java:
##########
@@ -1413,6 +1414,143 @@ private static List<TestSetSpec> jsonObjectSpec() {
STRING().notNull()));
}
+ private static List<TestSetSpec> jsonTypeSpec() {
+ return List.of(
+ // One flag per JSON type.
+ TestSetSpec.forFunction(BuiltInFunctionDefinitions.JSON_TYPE)
+ .onFieldsWithData(
+ "{\"a\": true}", "[1, 2]", "true", "\"Hello,
World!\"", "66")
+ .andDataTypes(STRING(), STRING(), STRING(), STRING(),
STRING())
+ .testResult(
+ $("f0").jsonType(), "JSON_TYPE(f0)", "object",
STRING().nullable())
+ .testResult(
+ $("f1").jsonType(), "JSON_TYPE(f1)", "array",
STRING().nullable())
+ .testResult(
+ $("f2").jsonType(), "JSON_TYPE(f2)",
"boolean", STRING().nullable())
+ .testResult(
+ $("f3").jsonType(), "JSON_TYPE(f3)", "string",
STRING().nullable())
+ .testResult(
+ $("f4").jsonType(), "JSON_TYPE(f4)", "number",
STRING().nullable()),
+
+ // The flag follows the JSON grammar alone: a number has no
width, and a quoted
+ // value is a string whatever it spells.
+ TestSetSpec.forFunction(BuiltInFunctionDefinitions.JSON_TYPE)
+ .onFieldsWithData(
+ "11.1", "99999999999999999999",
"\"2015-01-01\"", "\"66\"")
+ .andDataTypes(STRING(), STRING(), STRING(), STRING())
+ .testResult(
+ $("f0").jsonType(), "JSON_TYPE(f0)", "number",
STRING().nullable())
+ .testResult(
+ $("f1").jsonType(), "JSON_TYPE(f1)", "number",
STRING().nullable())
+ .testResult(
+ $("f2").jsonType(), "JSON_TYPE(f2)", "string",
STRING().nullable())
+ .testResult(
+ $("f3").jsonType(), "JSON_TYPE(f3)", "string",
STRING().nullable()),
+
+ // A SQL NULL input and invalid JSON both yield SQL NULL; the
JSON null literal
+ // returns the string 'null'.
+ TestSetSpec.forFunction(BuiltInFunctionDefinitions.JSON_TYPE)
+ .onFieldsWithData("68s", "null")
+ .andDataTypes(STRING(), STRING())
+ .testResult(
+ nullOf(STRING()).jsonType(),
+ "JSON_TYPE(CAST(NULL AS STRING))",
+ null,
+ STRING().nullable())
+ .testResult($("f0").jsonType(), "JSON_TYPE(f0)", null,
STRING().nullable())
+ .testResult(
+ $("f1").jsonType(), "JSON_TYPE(f1)", "null",
STRING().nullable())
+ .testResult(
+ $("f1").jsonType("$"),
+ "JSON_TYPE(f1, '$')",
+ "null",
+ STRING().nullable())
+ .testResult(
+ $("f1").jsonType("$.a"),
+ "JSON_TYPE(f1, '$.a')",
+ null,
+ STRING().nullable()),
+
+ // A path reads the type at that location instead of the root,
and yields NULL
+ // unless it resolves to exactly one value. A wildcard path is
indefinite: it reads
+ // back as a list, so it has a type only for a single match.
+ TestSetSpec.forFunction(BuiltInFunctionDefinitions.JSON_TYPE)
+ .onFieldsWithData("{\"a\": [1, 2]}", "{\"a\": [1]}")
+ .andDataTypes(STRING(), STRING())
+ .testResult(
+ $("f0").jsonType("$.a"),
+ "JSON_TYPE(f0, '$.a')",
+ "array",
+ STRING().nullable())
+ .testResult(
+ $("f0").jsonType("$.a[0]"),
+ "JSON_TYPE(f0, '$.a[0]')",
+ "number",
+ STRING().nullable())
+ .testResult(
+ $("f0").jsonType("$.b"),
+ "JSON_TYPE(f0, '$.b')",
+ null,
+ STRING().nullable())
+ .testResult(
+ $("f0").jsonType("$.["),
+ "JSON_TYPE(f0, '$.[')",
+ null,
+ STRING().nullable())
+ .testResult(
+ $("f0").jsonType(""),
+ "JSON_TYPE(f0, '')",
+ null,
+ STRING().nullable())
+ .testResult(
+ $("f0").jsonType("$.a[*]"),
+ "JSON_TYPE(f0, '$.a[*]')",
+ null,
+ STRING().nullable())
+ .testResult(
+ $("f1").jsonType("$.a[*]"),
+ "JSON_TYPE(f1, '$.a[*]')",
+ "number",
+ STRING().nullable()),
+
+ // The 'lax'/'strict' path mode prefix is rejected at planning
time.
+ TestSetSpec.forFunction(BuiltInFunctionDefinitions.JSON_TYPE)
Review Comment:
nit: add the test case we discussed for the case the field is called lax and
this works
##########
flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/api/internal/BaseExpressions.java:
##########
@@ -2507,6 +2508,53 @@ public OutType jsonQuery(
return jsonQuery(path, DataTypes.STRING(), wrappingBehavior, onEmpty,
onError);
}
+ /**
+ * Returns a string value indicating the type of the input.
+ *
+ * <p>Potential outputs are as following
+ *
+ * <ul>
+ * <li>object
+ * <li>array
+ * <li>string
+ * <li>number
+ * <li>boolean
+ * <li>null, for the JSON null literal
+ * </ul>
+ *
+ * <p>Every number is reported as number, whatever its magnitude or
precision.
+ *
+ * <p>Returns SQL NULL if the input is NULL or is not valid JSON.
+ *
+ * <p>Examples:
+ *
+ * <pre>{@code
+ * lit("{\"a\": true}").jsonType() // "object"
+ * lit("[1, 2]").jsonType() // "array"
+ * lit("null").jsonType() // "null"
+ * lit("\"Hello, World!\"").jsonType() // "string"
+ * lit("\"2015-01-01\"").jsonType() // "string"
+ * lit("66").jsonType() // "number"
+ * lit("11.1").jsonType() // "number"
+ * lit("68s").jsonType() // null, not valid JSON
Review Comment:
```suggestion
* lit("68s").jsonType() // SQL NULL, not valid JSON
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
