weiqingy commented on issue #999: URL: https://github.com/apache/flink-agents/issues/999#issuecomment-5274073089
Hi @kaiwangleo, thanks for going through the code on this. Your read matches what #1001 does, step for step. On the compatibility question, I am comfortable with it: only filtered `queryEmbedding` calls change, and today those are returning the wrong thing anyway. The gap #1001 leaves is CI. `ElasticsearchVectorStoreTest` is still `@Disabled`, so even the new regression test never runs there. That is the piece I would most like to see fixed, and it is yours if you want it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
