joeyutong commented on code in PR #938:
URL: https://github.com/apache/flink-agents/pull/938#discussion_r3886397627
##########
runtime/src/main/java/org/apache/flink/agents/runtime/operator/ActionExecutionOperator.java:
##########
@@ -504,28 +549,18 @@ private void processActionTaskForKey(Object key, String
contextKey) throws Excep
outputEvents = actionTaskResult.getOutputEvents();
generatedActionTaskOpt =
actionTaskResult.getGeneratedActionTask();
if (isFinished) {
- notifyActionFinished(actionTask);
+ notifyActionResultPersisted(actionTask);
Review Comment:
Could this produce two terminal Trace events when a later listener throws?
`EventLogTaskLifecycleListener` may already have emitted `finished` here, but
the exception is then caught below and `notifyActionFailed` emits `failed` for
the same execution, even though the Action result has already been persisted.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
