pltbkd commented on PR #938:
URL: https://github.com/apache/flink-agents/pull/938#issuecomment-5493011222
@joeyutong
Thanks for the review. All three comments are addressed:
- `notifyActionStarted` has been moved into the try block.
- The javadoc of `EventLogTaskLifecycleListener` has been updated.
- `notifyActionFinished` and `notifyActionFailed` cannot really be made
strictly
mutually exclusive, but I've updated the listener javadoc accordingly: the
framework still allows a listener to perform check-like work and throw (for
example, a sub-agent checking at finishing time that all call results have
been handled), while by convention an observational listener should avoid
throwing — consistent with the existing implementation of the EventLog
module.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
