raminqaf commented on PR #29041: URL: https://github.com/apache/flink/pull/29041#issuecomment-5477947675
> `flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/typeutils/TypeCheckUtils.java:149` (`isComparable`): nit: it excludes `BITMAP` and `VARIANT` explicitly but not `UUID`. I think it needs the same treatment now, even with codegen as a follow-up - otherwise `ORDER BY`/joins on a UUID column could crash confusingly instead of failing validation cleanly in the meantime. Make sense? Good catch, agreed. isComparable returns true for `UUID` today, so `ORDER BY`, joins, and comparisons on a `UUID` column pass validation and then hit codegen, which has no `UUID` support yet. Added it to `TypeCheckUtils` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
