raminqaf commented on code in PR #29041:
URL: https://github.com/apache/flink/pull/29041#discussion_r3898139668
##########
flink-table/flink-table-common/src/main/java/org/apache/flink/table/api/DataTypes.java:
##########
@@ -1075,6 +1076,17 @@ public static DataType BITMAP() {
return new AtomicDataType(new BitmapType());
}
+ /**
+ * Data type of a universally unique identifier (UUID).
+ *
+ * <p>The type represents a 128-bit value stored as a fixed 16-byte
big-endian sequence.
Review Comment:
Good point. The type is version-agnostic. It stores any 128-bit UUID in the
canonical 16-byte big-endian layout defined by RFC 9562 (which obsoletes RFC
4122), and it does not inspect or validate the version/variant bits, so v1, v4,
v7, and so on all map to the same UUID type. Versions are only relevant to
generation, which lands separately as UUID_V4() / UUID_V7() in FLINK-40489. I
will reword the javadoc to say this explicitly so it does not read as tied to
one version.
##########
flink-table/flink-table-common/src/main/java/org/apache/flink/table/types/logical/UuidType.java:
##########
@@ -0,0 +1,85 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.table.types.logical;
+
+import org.apache.flink.annotation.PublicEvolving;
+
+import java.util.Collections;
+import java.util.List;
+import java.util.Set;
+import java.util.UUID;
+
+/**
+ * Data type of a universally unique identifier (UUID).
+ *
+ * <p>The type represents a 128-bit value stored as a fixed 16-byte big-endian
sequence, following
+ * RFC 4122.
+ *
+ * <p>The serializable string representation of this type is {@code UUID}.
+ */
+@PublicEvolving
+public final class UuidType extends LogicalType {
+
+ private static final long serialVersionUID = 1L;
+
+ private static final Set<String> INPUT_OUTPUT_CONVERSION =
conversionSet(UUID.class.getName());
+
+ public UuidType(boolean isNullable) {
+ super(isNullable, LogicalTypeRoot.UUID);
+ }
+
+ public UuidType() {
+ this(true);
+ }
+
+ @Override
+ public LogicalType copy(boolean isNullable) {
+ return new UuidType(isNullable);
+ }
+
+ @Override
+ public String asSerializableString() {
+ return withNullability("UUID");
+ }
+
+ @Override
+ public boolean supportsInputConversion(Class<?> clazz) {
+ return INPUT_OUTPUT_CONVERSION.contains(clazz.getName());
+ }
+
+ @Override
+ public boolean supportsOutputConversion(Class<?> clazz) {
+ return INPUT_OUTPUT_CONVERSION.contains(clazz.getName());
+ }
+
+ @Override
+ public Class<?> getDefaultConversion() {
+ return UUID.class;
+ }
+
+ @Override
+ public List<LogicalType> getChildren() {
+ return Collections.emptyList();
Review Comment:
Addressed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
