snuyanzin commented on code in PR #29106:
URL: https://github.com/apache/flink/pull/29106#discussion_r3943438954
##########
flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/plan/nodes/exec/stream/DeletesByKeyPrograms.java:
##########
@@ -283,15 +286,186 @@ public final class DeletesByKeyPrograms {
.addSchema(
"id INT PRIMARY KEY NOT ENFORCED",
"name STRING",
- "`value` INT")
+ "v INT")
.addOption("changelog-mode", "I,UA,D")
.addOption("sink.supports-delete-by-key",
"true")
.testMaterializedData()
.consumedValues("+I[2, BOB, 20]", "+I[3,
Emily, 40]")
.build())
.runSql(
- "INSERT INTO sink_t SELECT l.id, r.name, l.`value`
FROM left_t l JOIN right_t r ON l.id = r.id")
+ "INSERT INTO sink_t SELECT l.id, r.name, l.v FROM
left_t l JOIN right_t r ON l.id = r.id")
+ .build();
+
+ public static final TableTestProgram
DELETE_BY_KEY_DELETE_BY_KEY_WITH_EXPRESSION =
+ TableTestProgram.of(
+ "delete-by-key-delete-by-key-with-expression",
+ "NOT NULL constrains have no effect. The row
constructor expression"
Review Comment:
```suggestion
"NOT NULL constraints have no effect. The row
constructor expression"
```
typo?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
