snuyanzin commented on code in PR #29106:
URL: https://github.com/apache/flink/pull/29106#discussion_r3943443837
##########
flink-table/flink-table-planner/src/main/scala/org/apache/flink/table/planner/codegen/CalcCodeGenerator.scala:
##########
@@ -146,28 +152,71 @@ object CalcCodeGenerator {
s"${OperatorCodeGenerator.generateCollect(resultTerm)}"
}
- def produceProjectionCode: String = {
- val projection = rexProgram.getProjectList.asScala
+ def produceFullProjectionCode: String = {
+ val fullProjectList = rexProgram.getProjectList.asScala
- val projectionExprs = projection.map(exprGenerator.generateExpression)
- val projectionExpression =
- exprGenerator.generateResultExpression(projectionExprs, outRowType,
outRowClass)
+ val expressions = fullProjectList.map(exprGenerator.generateExpression)
+ val resultExpression =
+ exprGenerator.generateResultExpression(expressions, outRowType,
outRowClass)
- val projectionExpressionCode = projectionExpression.code
+ val projectionExpressionCode = resultExpression.code
Review Comment:
if we rename `projectionExpression` to `resultExpression`, should we also
rename this var?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
