CodeTrainerMan commented on issue #1106: URL: https://github.com/apache/flink-agents/issues/1106#issuecomment-5734433265
Thanks for the detailed breakdown. I would like to take the **Watsonx** portion. It is independent from the Anthropic mapping already submitted in #1107, and the scope you described is unambiguous, so I plan to follow it exactly: * retain the reason reported by the provider verbatim (Watsonx already emits the shared vocabulary, so no mapping table is needed); * add no metadata key when the provider reports no finish reason; * keep the finish-reason metadata out of the outbound provider payload; * cover both the Java and Python Watsonx chat model connections, with tests. Before I write code I have two questions so the first PR lands in the right shape: 1. Naming: should the metadata key match the one #1107 introduced for Anthropic (I will read that patch and follow it) or is there a shared constant for finish reason that both providers are expected to use? 2. Does Watsonx need to go through the shared response path from #1040 the same way #1107 does for Anthropic, or is it wired up differently? I will keep the PR scoped to Watsonx only and wait for your ack before opening it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
