CodeTrainerMan commented on issue #1106: URL: https://github.com/apache/flink-agents/issues/1106#issuecomment-5734456892
Update before I write any code: I checked `main` and the Watsonx portion is **already done**, so I am withdrawing my claim on it. #1113 (`[integrations][java][python] Preserve Watsonx finish_reason in extra_args`, by @Ashfaqbs, merged 2026-09-14) covers both sides, and matches the scope described here: * Java - `WatsonxChatModelConnection.parseResponse()` writes `extraArgs["finish_reason"]` verbatim, with tests for `stop`, an unrecognized vendor reason, an absent `finish_reason` member, an explicit JSON `null`, and for capture working independently of the usage branch. * Python - `WatsonxChatModelConnection.chat()` does the same, with tests for verbatim capture and for the key being absent when the provider reports none. * Neither `convertMessages` (Java) nor `convert_to_watsonx_messages` (Python) carries `extra_args` into the outbound payload, so the metadata stays out of the request. The issue body still states "Watsonx remains an independent, unstarted follow-up", which is what I based my claim on. It would help the next reader if the body pointed at #1113 and marked the Watsonx part closed. One observation on the Anthropic half while I was reading #1107 against the mapping proposed here: #1107 keeps `end_turn` as `end_turn`, whereas this issue proposed `end_turn`/`stop_sequence` ? `stop`. Preserving the provider vocabulary looks like a deliberate narrowing, and the "preserve unrecognized reasons" wording here can be read either way - so I am not filing anything, but if that was intentional it may be worth noting in the issue so the Anthropic portion also reads as settled. Happy to pick up something else; I will look at the other open issues instead. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
